feat: delete sharedkey if invalid and attempt other auth method#253
feat: delete sharedkey if invalid and attempt other auth method#253
Conversation
|
Could it be an idea that: I.e. we don´t do any validation up front and we don´t do any special retries and what not. But if we detect that a sharedkey is invalid we delete it before exiting. In theory it will then "just work" if the user tries again. |
|
That's a good idea, I think... the code becomes a bit simpler, and we still manage to get rid of the invalid token. We should probably print out something to let the user know that a retry might help. |
|
Do you want to give that a go @atadj ?
|
I think yes, I can work on it! |
|
I just realised that my commit messages don't respect the semantic commit messages structure 😐, will be better for next commits hopefully |
|
Not a problem with the commit messages... you'll get a chance to edit the messages if you do a "squash and merge". |
…_token response instead
This is related to the issue #251
This is a suggested solution for deleting the shared key if not valid, and then try to authenticate again.