Skip to content

Conversation

@kakserpom
Copy link
Contributor

Description

Implements #493

@coveralls
Copy link

coveralls commented Dec 9, 2025

Pull Request Test Coverage Report for Build 20173570354

Details

  • 15 of 42 (35.71%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 35.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/array/array_key.rs 5 10 50.0%
src/types/array/conversions/btree_set.rs 5 16 31.25%
src/types/array/conversions/hash_set.rs 5 16 31.25%
Files with Coverage Reduction New Missed Lines %
src/types/array/array_key.rs 2 53.06%
Totals Coverage Status
Change from base Build 20110536661: -0.04%
Covered Lines: 1611
Relevant Lines: 4578

💛 - Coveralls

@kakserpom kakserpom force-pushed the 493_feat_sets_in_arguments branch 3 times, most recently from be00b05 to 3a743b0 Compare December 9, 2025 15:31
@kakserpom kakserpom force-pushed the 493_feat_sets_in_arguments branch from 3a743b0 to 455b192 Compare December 9, 2025 15:34
@Xenira
Copy link
Member

Xenira commented Dec 9, 2025

Thanks. Can you add unit tests?

@kakserpom
Copy link
Contributor Author

I am not sure what should be tested here.

Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation! Just some comments.

@ptondereau
Copy link
Member

ptondereau commented Dec 10, 2025

I am not sure what should be tested here.

for example:

#[test]
fn test_hash_table_try_from_hash_set() {
      Embed::run(|| {
          let mut set = HashSet::new();
          set.insert("one");
          let ht: ZBox<ZendHashTable> = set.try_into().unwrap();
          assert_eq!(ht.len(), 1);
          assert!(ht.get(0).is_some());
      });
}

@kakserpom kakserpom force-pushed the 493_feat_sets_in_arguments branch 2 times, most recently from 93b1a3c to 99a40db Compare December 10, 2025 19:51
@kakserpom kakserpom force-pushed the 493_feat_sets_in_arguments branch from 99a40db to d36bd8d Compare December 12, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants