-
-
Notifications
You must be signed in to change notification settings - Fork 77
feat(types): Argument coercion into HashSet/BTreeSet #493 #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kakserpom
wants to merge
2
commits into
extphprs:master
Choose a base branch
from
kakserpom:493_feat_sets_in_arguments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20173570354Details
💛 - Coveralls |
be00b05 to
3a743b0
Compare
3a743b0 to
455b192
Compare
Member
|
Thanks. Can you add unit tests? |
Contributor
Author
|
I am not sure what should be tested here. |
1 task
ptondereau
reviewed
Dec 10, 2025
Member
ptondereau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the implementation! Just some comments.
Member
for example: #[test]
fn test_hash_table_try_from_hash_set() {
Embed::run(|| {
let mut set = HashSet::new();
set.insert("one");
let ht: ZBox<ZendHashTable> = set.try_into().unwrap();
assert_eq!(ht.len(), 1);
assert!(ht.get(0).is_some());
});
} |
93b1a3c to
99a40db
Compare
99a40db to
d36bd8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #493