Support module.property.useHook() in Fast Refresh
#35318
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 4174533...217828a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
This was referenced Dec 7, 2025
|
The issue you linked in the description is incorrect. Should be vitejs/vite-plugin-react#1006, right? |
Contributor
Author
|
yeah my bad! |
Copilot AI
added a commit
to oxc-project/oxc
that referenced
this pull request
Dec 8, 2025
…fresh Add support for detecting hooks called via nested member expressions like `FancyHook.property.useNestedThing()` in React Fast Refresh. Previously, only direct hook calls and single-level member expressions were supported. This caused nested member expression hooks to force a full reset on HMR instead of preserving state. This implementation matches React PR #35318: facebook/react#35318 Co-authored-by: Dunqing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes vitejs/vite-plugin-react#1006
I'm not sure a lot of users do nest hooks at the second level, but the added complexity to the Babel plugin fells low enough to add support to it.
Before this change, the signature for the test would have been
_s(App, "useNestedThing{foo}", true)which would force reset on HMR.