Skip to content

Initialize Telemetry in Angular error handler constructor #9417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewbrook merged 1 commit into from
Dec 9, 2025
Merged

Initialize Telemetry in Angular error handler constructor #9417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/telemetry/src/angular/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { ErrorHandler, inject } from '@angular/core';
import { ActivatedRouteSnapshot, Router } from '@angular/router';
import { registerTelemetry } from '../register';
import { captureError, getTelemetry } from '../api';
import { TelemetryOptions } from '../public-types';
import { Telemetry, TelemetryOptions } from '../public-types';
import { FirebaseApp } from '@firebase/app';

registerTelemetry();
Expand Down Expand Up @@ -79,20 +79,21 @@ export * from '../public-types';
*/
export class FirebaseErrorHandler implements ErrorHandler {
private readonly router = inject(Router);
private readonly telemetry: Telemetry;

constructor(
private app: FirebaseApp,
private telemetryOptions?: TelemetryOptions
) {}
) {
this.telemetry = getTelemetry(this.app, this.telemetryOptions);
Comment on lines 85 to +88
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The constructor parameters app and telemetryOptions are only used within the constructor to initialize the telemetry property. They don't need to be stored as class properties. You can remove the private modifier from them and adjust the call to getTelemetry accordingly. This improves encapsulation by not exposing these properties on the class instance when they are not needed.

Suggested change
private app: FirebaseApp,
private telemetryOptions?: TelemetryOptions
) {}
) {
this.telemetry = getTelemetry(this.app, this.telemetryOptions);
app: FirebaseApp,
telemetryOptions?: TelemetryOptions
) {
this.telemetry = getTelemetry(app, telemetryOptions);

}

handleError(error: unknown): void {
const telemetry = getTelemetry(this.app, this.telemetryOptions);

const attributes = {
'angular_route_path': this.getSafeRoutePath(this.router)
};

captureError(telemetry, error, attributes);
captureError(this.telemetry, error, attributes);
}

/**
Expand Down
Loading