Skip to content

Conversation

@tonybaroneee
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

⚠️ No Changeset found

Latest commit: d15359e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tonybaroneee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a comprehensive renaming effort, transitioning the telemetry package and its associated components to crashlytics. This change clarifies the package's primary function, which is focused on error reporting and crash logging. The modifications span across API definitions, internal code logic, and extensive documentation, ensuring that all references and functionalities are consistently updated to reflect the new crashlytics identity.

Highlights

  • Package Renaming: The core telemetry package has been comprehensively renamed to crashlytics, affecting its main package and specific integrations for Angular and React.
  • API and Interface Updates: All public-facing APIs, interfaces, and internal service names have been updated from Telemetry to Crashlytics (e.g., getTelemetry is now getCrashlytics, TelemetryOptions is now CrashlyticsOptions).
  • Documentation Overhaul: Extensive changes were made to the documentation, including renaming markdown files, updating the table of contents (_toc.yaml), and revising content to reflect the new crashlytics naming across all relevant sections.
  • Internal Code Consistency: Internal constants, imports, and references across various source files (e.g., constants.ts, helpers.ts, register.ts) have been updated to align with the crashlytics nomenclature, ensuring full consistency throughout the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request primarily renames the @firebase/telemetry package and its associated components, interfaces, and documentation to @firebase/crashlytics. This involves updating file names, package names, import paths, variable names, and type definitions across the codebase, including API reports, documentation files, and source code for Angular and React integrations. The changes also include updating references in build scripts and package configurations. Review comments highlight the need to correct an incorrect import path in an example code snippet and to fix typos and outdated service references (from 'Telemetry service' to 'Crashlytics service') in several documentation comments.

tonybaroneee and others added 6 commits December 15, 2025 15:34
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (5c95051)Merge (978e6c8)Diff
    browser19.6 kB19.6 kB+4 B (+0.0%)
    main20.5 kB20.5 kB+4 B (+0.0%)
    module19.6 kB19.6 kB+4 B (+0.0%)
    react-native20.5 kB20.5 kB+4 B (+0.0%)
  • @firebase/crashlytics

    TypeBase (5c95051)Merge (978e6c8)Diff
    browser?9.71 kB? (?)
    main?8.69 kB? (?)
    module?9.71 kB? (?)
  • @firebase/database-compat/standalone

    TypeBase (5c95051)Merge (978e6c8)Diff
    main366 kB366 kB+4 B (+0.0%)
  • bundle

    46 size changes

    TypeBase (5c95051)Merge (978e6c8)Diff
    analytics (logEvent)44.1 kB44.1 kB+4 B (+0.0%)
    app-check (CustomProvider)37.3 kB37.3 kB+4 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)39.6 kB39.6 kB+4 B (+0.0%)
    app-check (ReCaptchaV3Provider)39.6 kB39.6 kB+4 B (+0.0%)
    auth (Anonymous)74.8 kB74.8 kB+4 B (+0.0%)
    auth (EmailAndPassword)84.5 kB84.5 kB+4 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)106 kB106 kB+4 B (+0.0%)
    auth (GooglePopup)98.2 kB98.2 kB+4 B (+0.0%)
    auth (GoogleRedirect)98.3 kB98.3 kB+4 B (+0.0%)
    auth (Phone)91.8 kB91.8 kB+4 B (+0.0%)
    database (Append to a list of data)154 kB154 kB+4 B (+0.0%)
    database (Filtering data)153 kB153 kB+4 B (+0.0%)
    database (Listen for child events)169 kB169 kB+4 B (+0.0%)
    database (Listen for value events + Detach listeners)169 kB169 kB+4 B (+0.0%)
    database (Listen for value events)169 kB169 kB+4 B (+0.0%)
    database (Read data once)168 kB168 kB+4 B (+0.0%)
    database (Save data as transactions)171 kB171 kB+4 B (+0.0%)
    database (Sort data)154 kB154 kB+4 B (+0.0%)
    database (Write data)153 kB153 kB+4 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)286 kB286 kB+4 B (+0.0%)
    firestore (CSI Auto Indexing Enable)286 kB286 kB+4 B (+0.0%)
    firestore (Persistence)318 kB318 kB+4 B (+0.0%)
    firestore (Query Cursors)257 kB257 kB+4 B (+0.0%)
    firestore (Query)255 kB255 kB+4 B (+0.0%)
    firestore (Read data once)245 kB245 kB+4 B (+0.0%)
    firestore (Read Write w Persistence)338 kB338 kB+4 B (+0.0%)
    firestore (Realtime updates)245 kB245 kB+4 B (+0.0%)
    firestore (Transaction)223 kB223 kB+4 B (+0.0%)
    firestore (Write data)225 kB225 kB+4 B (+0.0%)
    firestore-lite (Query Cursors)110 kB110 kB+4 B (+0.0%)
    firestore-lite (Query)106 kB106 kB+4 B (+0.0%)
    firestore-lite (Read data once)81.7 kB81.7 kB+4 B (+0.0%)
    firestore-lite (Transaction)107 kB107 kB+4 B (+0.0%)
    firestore-lite (Write data)91.2 kB91.2 kB+4 B (+0.0%)
    functions (call)38.8 kB38.8 kB+4 B (+0.0%)
    messaging (send + receive)46.4 kB46.5 kB+4 B (+0.0%)
    performance (trace)62.1 kB62.1 kB+4 B (+0.0%)
    remote-config (getAndFetch)59.5 kB59.5 kB+4 B (+0.0%)
    storage (getBytes)46.6 kB46.6 kB+4 B (+0.0%)
    storage (getDownloadURL)48.7 kB48.7 kB+4 B (+0.0%)
    storage (getMetadata)48.2 kB48.2 kB+4 B (+0.0%)
    storage (list + listAll)47.6 kB47.6 kB+4 B (+0.0%)
    storage (updateMetadata)48.4 kB48.4 kB+4 B (+0.0%)
    storage (uploadBytes)53.3 kB53.3 kB+4 B (+0.0%)
    storage (uploadBytesResumable)63.2 kB63.2 kB+4 B (+0.0%)
    storage (uploadString)53.5 kB53.5 kB+4 B (+0.0%)

  • firebase

    TypeBase (5c95051)Merge (978e6c8)Diff
    firebase-app-compat.js31.6 kB31.6 kB+4 B (+0.0%)
    firebase-app.js103 kB103 kB+4 B (+0.0%)
    firebase-compat.js809 kB809 kB+4 B (+0.0%)
    firebase-crashlytics.js?88.8 kB? (?)
    firebase-performance-standalone-compat.js105 kB105 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bCEPMkca9d.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 15, 2025

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (5c95051)Merge (084e77a)Diff
    browser19.6 kB19.6 kB+4 B (+0.0%)
    main20.5 kB20.5 kB+4 B (+0.0%)
    module19.6 kB19.6 kB+4 B (+0.0%)
    react-native20.5 kB20.5 kB+4 B (+0.0%)
  • @firebase/crashlytics

    TypeBase (5c95051)Merge (084e77a)Diff
    browser?9.71 kB? (?)
    main?8.69 kB? (?)
    module?9.71 kB? (?)
  • @firebase/database-compat/standalone

    TypeBase (5c95051)Merge (084e77a)Diff
    main366 kB366 kB+4 B (+0.0%)
  • bundle

    46 size changes

    TypeBase (5c95051)Merge (084e77a)Diff
    analytics (logEvent)44.1 kB44.1 kB+4 B (+0.0%)
    app-check (CustomProvider)37.3 kB37.3 kB+4 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)39.6 kB39.6 kB+4 B (+0.0%)
    app-check (ReCaptchaV3Provider)39.6 kB39.6 kB+4 B (+0.0%)
    auth (Anonymous)74.8 kB74.8 kB+4 B (+0.0%)
    auth (EmailAndPassword)84.5 kB84.5 kB+4 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)106 kB106 kB+4 B (+0.0%)
    auth (GooglePopup)98.2 kB98.2 kB+4 B (+0.0%)
    auth (GoogleRedirect)98.3 kB98.3 kB+4 B (+0.0%)
    auth (Phone)91.8 kB91.8 kB+4 B (+0.0%)
    database (Append to a list of data)154 kB154 kB+4 B (+0.0%)
    database (Filtering data)153 kB153 kB+4 B (+0.0%)
    database (Listen for child events)169 kB169 kB+4 B (+0.0%)
    database (Listen for value events + Detach listeners)169 kB169 kB+4 B (+0.0%)
    database (Listen for value events)169 kB169 kB+4 B (+0.0%)
    database (Read data once)168 kB168 kB+4 B (+0.0%)
    database (Save data as transactions)171 kB171 kB+4 B (+0.0%)
    database (Sort data)154 kB154 kB+4 B (+0.0%)
    database (Write data)153 kB153 kB+4 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)286 kB286 kB+4 B (+0.0%)
    firestore (CSI Auto Indexing Enable)286 kB286 kB+4 B (+0.0%)
    firestore (Persistence)318 kB318 kB+4 B (+0.0%)
    firestore (Query Cursors)257 kB257 kB+4 B (+0.0%)
    firestore (Query)255 kB255 kB+4 B (+0.0%)
    firestore (Read data once)245 kB245 kB+4 B (+0.0%)
    firestore (Read Write w Persistence)338 kB338 kB+4 B (+0.0%)
    firestore (Realtime updates)245 kB245 kB+4 B (+0.0%)
    firestore (Transaction)223 kB223 kB+4 B (+0.0%)
    firestore (Write data)225 kB225 kB+4 B (+0.0%)
    firestore-lite (Query Cursors)110 kB110 kB+4 B (+0.0%)
    firestore-lite (Query)106 kB106 kB+4 B (+0.0%)
    firestore-lite (Read data once)81.7 kB81.7 kB+4 B (+0.0%)
    firestore-lite (Transaction)107 kB107 kB+4 B (+0.0%)
    firestore-lite (Write data)91.2 kB91.2 kB+4 B (+0.0%)
    functions (call)38.8 kB38.8 kB+4 B (+0.0%)
    messaging (send + receive)46.4 kB46.5 kB+4 B (+0.0%)
    performance (trace)62.1 kB62.1 kB+4 B (+0.0%)
    remote-config (getAndFetch)59.5 kB59.5 kB+4 B (+0.0%)
    storage (getBytes)46.6 kB46.6 kB+4 B (+0.0%)
    storage (getDownloadURL)48.7 kB48.7 kB+4 B (+0.0%)
    storage (getMetadata)48.2 kB48.2 kB+4 B (+0.0%)
    storage (list + listAll)47.6 kB47.6 kB+4 B (+0.0%)
    storage (updateMetadata)48.4 kB48.4 kB+4 B (+0.0%)
    storage (uploadBytes)53.3 kB53.3 kB+4 B (+0.0%)
    storage (uploadBytesResumable)63.2 kB63.2 kB+4 B (+0.0%)
    storage (uploadString)53.5 kB53.5 kB+4 B (+0.0%)

  • firebase

    TypeBase (5c95051)Merge (084e77a)Diff
    firebase-app-compat.js31.6 kB31.6 kB+4 B (+0.0%)
    firebase-app.js103 kB103 kB+4 B (+0.0%)
    firebase-compat.js809 kB809 kB+4 B (+0.0%)
    firebase-crashlytics.js?88.8 kB? (?)
    firebase-performance-standalone-compat.js105 kB105 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/htA31RPNEK.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 15, 2025

Size Analysis Report 1

This report is too large (190,883 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uqcFj9J0u4.html

@tonybaroneee tonybaroneee merged commit 3908b8e into telemetry Dec 15, 2025
54 of 57 checks passed
@tonybaroneee tonybaroneee deleted the telemetry-rename-crashlytics branch December 15, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants