Skip to content

runtime: port finalize_account to accdb API #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ripatel-fd merged 2 commits into from
Dec 16, 2025
Merged

runtime: port finalize_account to accdb API #7571

ripatel-fd merged 2 commits into from
Dec 16, 2025

Conversation

@ripatel-fd
Copy link
Contributor

@ripatel-fd ripatel-fd commented Dec 10, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.050926 s 0.050901 s -0.049% ✅
backtest mainnet-368528500-perf snapshot load 1.637 s 1.621 s -0.977% ✅
backtest mainnet-368528500-perf total elapsed 50.92574 s 50.901185 s -0.048% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

ripatel-fd
ripatel-fd commented Dec 10, 2025
View reviewed changes
@ripatel-fd ripatel-fd force-pushed the ripatel/txn-finalize-accdb branch from 4725bcd to e23eace Compare December 10, 2025 13:44
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073175 s 0.073728 s 0.756% ✅
backtest mainnet-368528500-perf snapshot load 3.159 s 3.169 s 0.317% ✅
backtest mainnet-368528500-perf total elapsed 73.174655 s 73.727919 s 0.756% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

@ripatel-fd ripatel-fd force-pushed the ripatel/txn-finalize-accdb branch 2 times, most recently from 99f7ff7 to efba5bd Compare December 11, 2025 12:31
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073968 s 0.073604 s -0.492% ✅
backtest mainnet-368528500-perf snapshot load 3.2 s 3.203 s 0.094% ✅
backtest mainnet-368528500-perf total elapsed 73.968171 s 73.604034 s -0.492% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

@riptl
accdb: add open_rw truncate mode
c2a7d15 
Adds an API to modify an account while truncating the data region.
This is useful for callers who are going to replace account data
entirely (transaction processing).

Also fixes a val_sz corruption bug in fd_accdb_ref_data_(sz_)set.
@ripatel-fd ripatel-fd force-pushed the ripatel/txn-finalize-accdb branch from efba5bd to 4b2ef74 Compare December 16, 2025 20:24
@ripatel-fd ripatel-fd force-pushed the ripatel/txn-finalize-accdb branch from 4b2ef74 to 1519da7 Compare December 16, 2025 20:38
@ripatel-fd ripatel-fd enabled auto-merge (rebase) December 16, 2025 20:43
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.05058 s 0.050477 s -0.204% ✅
backtest mainnet-368528500-perf snapshot load 1.61 s 1.616 s 0.373% ✅
backtest mainnet-368528500-perf total elapsed 50.580123 s 50.476757 s -0.204% ✅
firedancer mem usage with mainnet.toml 1005.23 GiB 1005.23 GiB 0.000% ✅

@ripatel-fd ripatel-fd merged commit 3c288f2 into main Dec 16, 2025
13 checks passed
@ripatel-fd ripatel-fd deleted the ripatel/txn-finalize-accdb branch December 16, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmcgee-jump mmcgee-jump mmcgee-jump approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ripatel-fd @mmcgee-jump @riptl