replay: adding better metrics #7583
Merged
+108
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
mmcgee-jump
reviewed
Dec 15, 2025
ibhatt-jumptrading
changed the title
yufeng-jump
previously approved these changes
Dec 16, 2025
src/disco/metrics/metrics.xml
Outdated
|
|
||
| <counter name="SchedFull" summary="Times where sched is full and a FEC set can't be processed" /> | ||
| <counter name="ReasmEmpty" summary="Times where reasm is empty and a FEC set can't be processed" /> | ||
| <counter name="LeaderBidWait" summary="Times where replay is blocked by the the PoH tile not sending an end of leader message" /> |
src/discof/replay/fd_replay_tile.c
Outdated
| if( FD_UNLIKELY( (fec = fd_reasm_peek( ctx->reasm ))==NULL ) ) { | ||
| ctx->metrics.reasm_empty++; | ||
| ctx->metrics.reasm_latest_slot = ULONG_MAX; | ||
| ctx->metrics.reasm_latest_fec_idx = ULONG_MAX; |
Contributor
There was a problem hiding this comment.
We might want these to monotonically increase, rather than resetting to ULONG_MAX. The way metrics make their way into the database, we might miss some high watermark values if we reset? I don't think we lose any information if we keep the reasm_latest_* values untouched in this branch, since reasm_empty will go up and that'll indicate an empty reasm.
Contributor
Author
There was a problem hiding this comment.
yeah agreed
Performance Measurements ⏳
|
yufeng-jump
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.