Add Calcium support for complete elliptic integrals#2302
Open
lgoetzfried wants to merge 5 commits intoflintlib:mainfrom
Open
Add Calcium support for complete elliptic integrals#2302lgoetzfried wants to merge 5 commits intoflintlib:mainfrom
lgoetzfried wants to merge 5 commits intoflintlib:mainfrom
Conversation
lgoetzfried
changed the title
src/ca_field/build_ideal_elliptic.c
Outdated
Comment on lines
56
to
57
| ulong* exp = (ulong*) flint_malloc(len * sizeof(ulong)); | ||
| if (exp != NULL){ |
Collaborator
There was a problem hiding this comment.
You can always assume that exp != NULL.
src/ca_field/build_ideal_elliptic.c
Outdated
| ulong exp[len]; | ||
| for (slong v = 0; v < len; v++){ | ||
| exp[v] = 0; | ||
| ulong* exp = (ulong*) flint_malloc(len * sizeof(ulong)); |
Collaborator
There was a problem hiding this comment.
Use (1) alloca or (2) GR_TMP_ALLOC joined with GR_TMP_FREE (see gr.h). No need to use malloc for something small.
Author
There was a problem hiding this comment.
I have now changed it to GR_TMP_ALLOC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated, this PR would like to introduce complete elliptic integrals of the first, second and third kind with exact arguments in the Calcium framework:
ca_elliptic_k,ca_elliptic_eandca_elliptic_pi. In my opinion, support of multiple transcendental functions enhances the functionality and allows for more applications of the FLINT library, in particular since user-defined functions in Calcium are not yet supported.The implementation is quite basic. I have implemented the Legendre relation of the elliptic integrals to allow for some simplifications, but so far no further functional equations.
(I just encountered myself the situation that I would have liked to work with elliptic integrals, but did not find them implemented. I think that they can also be useful for anyone else, and in particular the implementation was almost cost-free. Thus I thought that maybe such a pull request would be sensible.)
Best regards.