Fix CSG intersection transform stability for downstream merges#302
Merged
tracygardner merged 3 commits intomainfrom Feb 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
centerMesh: falseandrebuildNormals: truewhen callingbaseCSG.toMesh(...)so the intersected mesh is generated in world-space.intersectedMesh.position = combinedCentre) and instead refresh the transform withintersectedMesh.computeWorldMatrix(true)to keep world placement stable.resultMesh.rotationQuaternion = flock.BABYLON.Quaternion.Identity()inapplyResultMeshPropertiesso copied rotation/quaternion data from the reference mesh is preserved.Testing
npm run test:api -- --grep "mergeMeshes geometry preparation|intersectMeshes"which failed in this CI environment because Playwright browser binaries are not installed (Playwright requestednpx playwright install).npm run lintwhich failed due to pre-existing lint issues inflock.jsunrelated to this change.npx eslint api/csg.jsduring development to validate the modified file; linting revealed file-level issues in the repository but the CSG-related logic changes are applied as intended.Codex Task