Draft
Conversation
This was referenced Dec 31, 2023
Introduce File type that checks existence of file on creation and is used in FSharpLintExecutableFile instead of string path.
ensure we can reuse an already found daemon version from another folder
knocte
reviewed
Dec 31, 2025
| "Clean" | ||
| ==> "Build" | ||
| ==> "Test" | ||
| // ==> "Test" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #637, so it should be merged first
See MrLuje/FSharpLint@9635b9a...MrLuje:FSharpLint:lint_layer diff for relevant changes
WIP on #627:
For reminder, the purpose of the API layer is to abstract away all FCS types so the caller can have a different FCS version than FSharpLint.
I duplicated types from https://github.com/fsprojects/FSharpLint/blob/master/src/FSharpLint.Core/Framework/Suggestion.fs to
FSharpLint.Clientand prefixed them withClient(eg:SuggestedFix=>ClientSuggestedFix) to tell them apart. (I createdClientRangefrom scratch to avoid the FCS dependency) but that's open to discussion.For now, the
LintFileRequesttakes the path to the file to lint and an optionalLintConfigPathto afsharplint.jsonfile but I'm wondering about other scenario :defaultConfigurationwill be used (same with an invalidLintConfigPath)fsharplint.jsonis specified throughLintConfigPath, it will be usedLintConfigPathisn't specified but there is an existingfsharplint.jsonin the project ? is there a standard location forfsharplint.jsonor an existing detection method ? (next to solution file, parse [fc]sproj, etc)