fix: remove the checking if metadata are already cached by filename

[Arukuen]

fixes #8

This check prevents the saving of the metadata since it assumes that files of the same filename are the same.

Checked the behavior for the following:

• Uploading a file, closing the media library, and uploading a different file with the same name
• Uploading of different files with the same name at the same time
• Uploading of different file types (audio, image, video)

[coderabbitai]

Walkthrough

The metadata-saver.js module was modified to remove an early-exit optimization that previously skipped execution when all metadata entries were cached. The function now always proceeds to cache entries and execute the network request, provided the input array contains non-null entries.

Changes

Cohort / File(s)	Summary
Metadata Caching Optimization Removal src/shared/metadata-saver.js	Removed early-exit condition that skipped caching and POST request when all metadata entries were already cached by filename. Function now unconditionally caches each entry and performs network request for non-empty input.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Consideration: Verify that removing the early-exit optimization aligns with intended behavior and does not introduce unnecessary network overhead or redundant cache operations.
• Consideration: Confirm the rationale for always executing the POST request even when metadata is fully cached, as this changes the previous efficiency pattern.

Poem

🐰 The cache once skipped when full of treasure,
But now we save with eager measure!
No early exits on this sunny day—
Every entry gets its say, hooray! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 5ae075e and eacea42.

📒 Files selected for processing (1)

• src/shared/metadata-saver.js (0 hunks)

💤 Files with no reviewable changes (1)

• src/shared/metadata-saver.js

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Pull request artifacts

file	commit
pr17-cimo-17-merge.zip	bcfc1f9