fix: don't show cimo notice if premium

[kaeizen]

fixes #3659

Summary by CodeRabbit

• Bug Fixes
  • Image control notice now correctly respects pro user status and remains hidden.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds isPro import to the image control component and extends the useEffect skip condition for the Cimo notice display. When isPro is truthy, the Cimo notice is skipped alongside existing checks for undefined cimo, hideNotice flag, or already-activated status.

Changes

Cohort / File(s)	Summary
Pro version gating for Cimo notice src/components/image-control2/index.js	Added isPro import from stackable; extended useEffect skip condition to prevent Cimo notice display when isPro is truthy

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify that the isPro flag correctly gates the Cimo notice behavior
• Confirm the conditional logic chain (cimo, hideNotice, activated, isPro) functions as intended
• Check that no other notice or feature logic is inadvertently affected by the new condition

Poem

🐰 A rabbit's code, so clean and tidy,
Pro users spared from notice-y Friday,
With isPro checked, the flow runs right,
Features gated, smooth and bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: adding logic to prevent the Cimo notice from displaying when the premium/pro flag is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/remove-cimo-in-premium

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Pull request artifacts

file	commit
pr3663-stackable-3663-merge.zip	879ed4a

[github-actions]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3663-stackable-3663-merge.zip"}}]}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/image-control2/index.js (1)

91-117: Cimo notice skip condition correctly extended for pro installs

The updated condition:

if ( isPro || ! cimo || cimo.hideNotice || cimo.status === 'activated' ) {
    return
}

correctly short‑circuits the effect for pro users, so the Cimo download notice will never be loaded/rendered in premium, while preserving the existing checks for missing Cimo, hidden notice, or already‑activated status. Given isPro/cimo are effectively config‑like globals, keeping the empty dependency array is fine here.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e6fb4d and 879ed4a.

📒 Files selected for processing (1)

• src/components/image-control2/index.js (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: PHP 8.2 and WP 6.6.2
• GitHub Check: PHP 8.2 and WP 6.7.2
• GitHub Check: PHP 7.3 and WP 6.5.5
• GitHub Check: PHP 8.2 and WP latest
• GitHub Check: build
• GitHub Check: PHP 7.3 and WP latest
• GitHub Check: PHP 8.2 and WP 6.5.5

🔇 Additional comments (1)

src/components/image-control2/index.js (1)

14-16: Confirm isPro export shape and usage

Importing isPro alongside i18n and cimo looks consistent, and the new usage in the effect matches the PR goal (gating the notice for pro installs). Just make sure that:

• isPro is indeed exported as a boolean/flag (not a function) from stackable.
• Other call sites (if any) use it in the same way so behavior stays consistent.

If isPro is a function, this should be isPro() instead, otherwise the notice will be skipped for everyone.