Change modifiers S3 artifact metadata to be a list of features#312
Merged
NotTheEvilOne merged 1 commit intomainfrom Feb 10, 2026
Merged
Change modifiers S3 artifact metadata to be a list of features#312NotTheEvilOne merged 1 commit intomainfrom
modifiers S3 artifact metadata to be a list of features#312NotTheEvilOne merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 91.68% 91.65% -0.03%
==========================================
Files 42 42
Lines 2129 2134 +5
==========================================
+ Hits 1952 1956 +4
- Misses 177 178 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
94dd78e to
febc8c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an regression in the generated S3 artifact metadata.
modifiersshould be a list of strings but was formatted as a,-separated string instead.