Skip to content

tests: General logs tests should use Sentry logs API #5262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 3 commits into from
Dec 19, 2025
Merged

tests: General logs tests should use Sentry logs API #5262

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9200eef
tests: General logs tests should use Sentry logs
sentrivana Dec 19, 2025
e311d5c
.
sentrivana Dec 19, 2025
1d37d0f
gate behind 3.7
sentrivana Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions tests/test_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,16 +342,16 @@ def test_logs_tied_to_spans(sentry_init, capture_envelopes):
assert logs[0]["span_id"] == span.span_id


@minimum_python_37
def test_auto_flush_logs_after_100(sentry_init, capture_envelopes):
"""
If you log >100 logs, it should automatically trigger a flush.
"""
sentry_init(enable_logs=True)
envelopes = capture_envelopes()

python_logger = logging.Logger("test-logger")
for i in range(200):
python_logger.warning("log #%d", i)
sentry_sdk.logger.warning("log")

for _ in range(500):
time.sleep(1.0 / 100.0)
Expand All @@ -361,15 +361,15 @@ def test_auto_flush_logs_after_100(sentry_init, capture_envelopes):
raise AssertionError("200 logs were never flushed after five seconds")


@minimum_python_37
def test_log_user_attributes(sentry_init, capture_envelopes):
"""User attributes are sent if enable_logs is True and send_default_pii is True."""
sentry_init(enable_logs=True, send_default_pii=True)

sentry_sdk.set_user({"id": "1", "email": "[email protected]", "username": "test"})
envelopes = capture_envelopes()

python_logger = logging.Logger("test-logger")
python_logger.warning("Hello, world!")
sentry_sdk.logger.warning("Hello, world!")

get_client().flush()

Expand All @@ -384,15 +384,15 @@ def test_log_user_attributes(sentry_init, capture_envelopes):
}


@minimum_python_37
def test_log_no_user_attributes_if_no_pii(sentry_init, capture_envelopes):
"""User attributes are not if PII sending is off."""
sentry_init(enable_logs=True, send_default_pii=False)

sentry_sdk.set_user({"id": "1", "email": "[email protected]", "username": "test"})
envelopes = capture_envelopes()

python_logger = logging.Logger("test-logger")
python_logger.warning("Hello, world!")
sentry_sdk.logger.warning("Hello, world!")

get_client().flush()

Expand All @@ -412,8 +412,7 @@ def test_auto_flush_logs_after_5s(sentry_init, capture_envelopes):
sentry_init(enable_logs=True)
envelopes = capture_envelopes()

python_logger = logging.Logger("test-logger")
python_logger.warning("log #%d", 1)
sentry_sdk.logger.warning("log")

for _ in range(100):
time.sleep(1.0 / 10.0)
Expand Down
Loading