Skip to content

Conversation

@ltzmaxwell
Copy link
Contributor

No description provided.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 26, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ltzmaxwell
Copy link
Contributor Author

alternative of #4444.

@ltzmaxwell ltzmaxwell changed the title WIP: fix(gnovm): alternative way to get last line fix(gnovm): alternative way to get last line Dec 1, 2025
@ltzmaxwell ltzmaxwell requested a review from thehowl December 1, 2025 05:24
@ltzmaxwell ltzmaxwell changed the title fix(gnovm): alternative way to get last line fix(gnovm): alternative way(of #4444) to get last line Dec 1, 2025
@ltzmaxwell ltzmaxwell requested a review from omarsy December 1, 2025 05:30
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️Gno.land development Dec 1, 2025
@Kouteki Kouteki requested a review from jaekwon December 1, 2025 16:21
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good in intent (keeping the last line simply in the machine), though maybe we should keep the tracking in OpExec / OpEval?

I don't know if that adequately captures all the cases we need; but I think the current changes don't consider, for instance, ForcePopOp or other ways of capturing the latest statement.

@ltzmaxwell
Copy link
Contributor Author

The approach looks good in intent (keeping the last line simply in the machine), though maybe we should keep the tracking in OpExec / OpEval?

yeah, sounds more correct: f911020

I don't know if that adequately captures all the cases we need; but I think the current changes don't consider, for instance, I don't know if that adequately captures all the cases we need; but I think the current changes don't consider, for instance, ForcePopOp or other ways of capturing the latest statement. or other ways of capturing the latest statement.

didn't fully get this, add a test for ForcePopOp, it looks works: a762d9e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 🤖 gnovm Issues or PRs gnovm related

Projects

Status: No status
Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants