-
Notifications
You must be signed in to change notification settings - Fork 440
fix(gnovm): alternative way(of #4444) to get last line #4914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
alternative of #4444. |
thehowl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good in intent (keeping the last line simply in the machine), though maybe we should keep the tracking in OpExec / OpEval?
I don't know if that adequately captures all the cases we need; but I think the current changes don't consider, for instance, ForcePopOp or other ways of capturing the latest statement.
yeah, sounds more correct: f911020
didn't fully get this, add a test for |
No description provided.