-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update setting up XR for Godot 4.3 #10510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c25335c to
1a2fb5b
Compare
BastiaanOlij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I don't have anything to add that @tetrapod00 hasn't already mentioned. With the openxr settings page I do think the links to the class reference are likely overkill. We should probably link the openxr settings page there if we haven't already.
|
In general, we should always link to the project settings when mentioning them. Much of the time the ProjectSettings class reference is the only place that includes robust descriptions. In the case of OpenXR, since there is a separate page just for the OpenXR settings (with longer descriptions), linking to the section headers in that page instead of the ProjectSettings class reference page seems fine instead. I do think that the exact name of the setting as it appears in the UI should at least be mentioned, whether or not it links anywhere, so that the page can be read without needing to rely on the image. |
|
I've made tetrapod's suggestions, and added a link to the OpenXR settings manual page. |
tetrapod00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this looks fine to me, if you were waiting for my approval. Feel free to merge
|
In this goes then. Thank you! :) |
Primarily updates the setting up XR page for Godot 4.3. Some images are used on other pages as well hence why they're updated here. I plan to go through those other pages in different PRs in the future, focusing on one page for this just to make things easier to review.
Did the following:
@BastiaanOlij Let me know if there's any of my changes you'd like modified, If there's anything else on this page you want updated. Or if I should pay particular attention to any of the other XR pages for text updates as I go through them.