Skip to content

create: Prevent panic when content file exists with different case #14256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tharunn0 wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Open

create: Prevent panic when content file exists with different case #14256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions hugolib/content_factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,26 @@ func (f ContentFactory) CreateContentPlaceHolder(filename string, force bool) (s
return "", err
}

if !force {
dir := filepath.Dir(abs)
base := filepath.Base(abs)

dirFile, err := f.h.Fs.Source.Open(dir)
if err == nil {
names, _ := dirFile.Readdirnames(-1)
dirFile.Close()
for _, name := range names {
if strings.EqualFold(name, base) {
if name == base {
return "", fmt.Errorf("content file already exists: %s", filename)
}
return "", fmt.Errorf("content file already exists with different case: %s (found as %s)",
filename, name)
}
}
}
}

// This will be overwritten later, just write a placeholder to get
// the paths correct.
placeholder := `---
Expand Down