Skip to content

Conversation

@sarojrout
Copy link
Contributor

@sarojrout sarojrout commented Nov 16, 2025

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sarojrout, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new sample AI agent, hello_doctor, designed to simulate a health assessment conversation. Its core purpose is to showcase how an AI can engage in structured, educational health dialogues while strictly adhering to safety protocols, such as disclaiming medical authority and recommending professional consultation. The agent gathers user information through specific questions and provides high-level, non-diagnostic summaries, serving as a robust example of responsible AI application in sensitive domains.

Highlights

  • New Sample Agent: Introduces a new hello_doctor health assessment agent sample, demonstrating safe and educational health conversations.
  • Structured Health Intake: The agent is designed to ask six key questions (age, smoking, alcohol, medical conditions/medications, allergies, lifestyle) before providing any advice.
  • Session State and Risk Assessment: Utilizes log_health_answer to track user responses longitudinally and summarize_risk_profile to provide non-diagnostic risk summaries.
  • Safety First: Emphasizes strong safety disclaimers, clearly stating it is not a medical professional and directing users to licensed healthcare providers for real health concerns.
  • Few-Shot Examples: Includes examples for handling various scenarios like mild symptoms, concerning symptoms, and supplement questions to guide the agent's behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the core [Component] This issue is related to the core interface and implementation label Nov 16, 2025
@adk-bot
Copy link
Collaborator

adk-bot commented Nov 16, 2025

Response from ADK Triaging Agent

Hello @sarojrout, thank you for creating this PR!

To help us review your contribution, could you please fill out the pull request template in the description?

Specifically, this PR would benefit from:

  • A link to an associated GitHub issue, or a more detailed description of the new hello_doctor agent.
  • A "Testing Plan" section that describes how you've tested these changes.

You can find more information in our contribution guidelines. This information will help reviewers to review your PR more efficiently. Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new hello_doctor sample agent, which demonstrates a health assessment conversation. The agent is well-structured with clear safety instructions, tools for session state management and risk summarization, and few-shot examples to guide its behavior. The accompanying main.py provides a helpful CLI for running and testing the agent. The code is clean and the sample is a valuable addition. I have one point of feedback regarding the model name used in the agent definition, which might need correction to ensure the sample runs correctly.

@ryanaiagent ryanaiagent self-assigned this Nov 18, 2025
@ryanaiagent
Copy link
Collaborator

ryanaiagent commented Nov 20, 2025

Hi @sarojrout , Thank you for your contribution!
Can you please fix the lint error and failing unit test before we proceed with the review.

@ryanaiagent ryanaiagent added the request clarification [Status] The maintainer need clarification or more information from the author label Nov 20, 2025
- Add error handling for empty config files in get_evaluation_criteria_or_default
- Catch ValidationError and ValueError when parsing JSON config
- Return default config with warning log when file is empty or invalid
- Add test case for empty file handling
- Fix pyink formatting issues in the sample files
@sarojrout
Copy link
Contributor Author

Hi @sarojrout , Thank you for your contribution! Can you please fix the lint error and failing unit test before we proceed with the review.

pushed the fix. pls verify. thanks!

@ryanaiagent
Copy link
Collaborator

Hi @sarojrout , to fix lint errors you can use autoformat.sh

@sarojrout
Copy link
Contributor Author

autoformat.sh

ya i ran and fixed the formatting errors in other files as well.

@ryanaiagent ryanaiagent added needs-review [Status] The PR is awaiting review from the maintainer and removed request clarification [Status] The maintainer need clarification or more information from the author labels Nov 21, 2025
@ryanaiagent
Copy link
Collaborator

Hi @DeanChensj , can you please review this.

@sarojrout
Copy link
Contributor Author

Hi @DeanChensj , can you please review this.

Hi @DeanChensj , can we close this?

@ryanaiagent ryanaiagent added request clarification [Status] The maintainer need clarification or more information from the author and removed needs-review [Status] The PR is awaiting review from the maintainer labels Jan 13, 2026
@ryanaiagent
Copy link
Collaborator

Hi @sarojrout, Thank you for your patience here. I apologize for the delay in getting to this review; I know this has been sitting for a while. This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core [Component] This issue is related to the core interface and implementation request clarification [Status] The maintainer need clarification or more information from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants