-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(samples): add hello_doctor health assessment agent #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sarojrout, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new sample AI agent, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @sarojrout, thank you for creating this PR! To help us review your contribution, could you please fill out the pull request template in the description? Specifically, this PR would benefit from:
You can find more information in our contribution guidelines. This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new hello_doctor sample agent, which demonstrates a health assessment conversation. The agent is well-structured with clear safety instructions, tools for session state management and risk summarization, and few-shot examples to guide its behavior. The accompanying main.py provides a helpful CLI for running and testing the agent. The code is clean and the sample is a valuable addition. I have one point of feedback regarding the model name used in the agent definition, which might need correction to ensure the sample runs correctly.
|
Hi @sarojrout , Thank you for your contribution! |
- Add error handling for empty config files in get_evaluation_criteria_or_default - Catch ValidationError and ValueError when parsing JSON config - Return default config with warning log when file is empty or invalid - Add test case for empty file handling - Fix pyink formatting issues in the sample files
pushed the fix. pls verify. thanks! |
|
Hi @sarojrout , to fix lint errors you can use autoformat.sh |
ya i ran and fixed the formatting errors in other files as well. |
|
Hi @DeanChensj , can you please review this. |
Hi @DeanChensj , can we close this? |
|
Hi @sarojrout, Thank you for your patience here. I apologize for the delay in getting to this review; I know this has been sitting for a while. This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review. |
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.