Rip out maven-release-plugin configuration.
#515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As best I can tell, this configuration has never offered anything over what we get by default from `maven-deploy-plugin` (or its modern replacement, `central-publishing-maven-plugin`). I wouldn't rule out that we've never actually used `maven-release-plugin` at all for our releases: We may have been running `mvn deploy` instead of `mvn release:prepare` + `mvn release:perform`. (Certainly the script that we use for most of our projects uses `mvn deploy` directly.) I looked into the `-DenableCiProfile` bit, and as best I can tell, we've never defined a property by that name, nor is it a standard part of Maven. I do see one defined in [the `pom.xml` for `maven-surefire-plugin`](https://central.sonatype.com/artifact/org.apache.maven.plugins/maven-surefire-plugin/3.1.0), but our setting the flag would have no effect on our _usage_ of Surefire; the setting there would matter only when _building_ Surefire. Anyway, this configuration dates back to cl/30835352 (Caliper) and cl/51674256 (Compile-Testing). I can't fully rule out that it's doing _something_ for _some_ process that _someone_ uses, but I'm highly comfortable removing it. We can always roll back if we somehow see trouble, and I don't expect any trouble in the first place. RELNOTES=n/a PiperOrigin-RevId: 831024758
copybara-service
bot
force-pushed
the
test_831002527
branch
from
2ca2192 to
084e365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rip out
maven-release-pluginconfiguration.As best I can tell, this configuration has never offered anything over what we get by default from
maven-deploy-plugin(or its modern replacement,central-publishing-maven-plugin).I wouldn't rule out that we've never actually used
maven-release-pluginat all for our releases: We may have been runningmvn deployinstead ofmvn release:prepare+mvn release:perform. (Certainly the script that we use for most of our projects usesmvn deploydirectly.)I looked into the
-DenableCiProfilebit, and as best I can tell, we've never defined a property by that name, nor is it a standard part of Maven. I do see one defined in thepom.xmlformaven-surefire-plugin, but our setting the flag would have no effect on our usage of Surefire; the setting there would matter only when building Surefire.Anyway, this configuration dates back to cl/30835352 (Caliper) and cl/51674256 (Compile-Testing). I can't fully rule out that it's doing something for some process that someone uses, but I'm highly comfortable removing it. We can always roll back if we somehow see trouble, and I don't expect any trouble in the first place.
RELNOTES=n/a