Test most of Crubit in GitHub CI. #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_840455787
branch
3 times, most recently
from
45955f1 to
59b27d7
Compare
This uses a `cargo test --workspace` command with some exclusions, which will build `cc_bindings_from_rs` like the previous CI workflow, but also will run all tests. I don't think there's much reason to keep the build check. Note that this excludes a decent fraction of the cargo workspace! Unfortunately, we still don't have easily working tests for rs_bindings_from_cc, because of the heroics currently required to install the C++ dependencies it has. That will wait to a later stage. PiperOrigin-RevId: 841902765
copybara-service
bot
force-pushed
the
test_840455787
branch
from
59b27d7 to
c5b0bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test most of Crubit in GitHub CI.
This uses a
cargo test --workspacecommand with some exclusions, which will buildcc_bindings_from_rslike the previous CI workflow, but also will run all tests. I don't think there's much reason to keep the build check.Note that this excludes a decent fraction of the cargo workspace! Unfortunately, we still don't have easily working tests for rs_bindings_from_cc, because of the heroics currently required to install the C++ dependencies it has. That will wait to a later stage.