feat(tojson): accept ensure_ascii kwarg for Jinja compatibility#84
Open
cnaples79 wants to merge 1 commit intogoogle:mainfrom
Open
feat(tojson): accept ensure_ascii kwarg for Jinja compatibility#84cnaples79 wants to merge 1 commit intogoogle:mainfrom
cnaples79 wants to merge 1 commit intogoogle:mainfrom
Conversation
…google#82)\n\n- Extend built-in tojson to accept optional ensure_ascii (ignored, preserves UTF-8 default)\n- Add test ensuring tojson(ensure_ascii=False) does not error
This was referenced Nov 2, 2025
Closed
ochafik
added a commit
to ochafik/minja
that referenced
this pull request
Nov 2, 2025
Fixes #4 - Fix parsing of values (nested method calls on function calls, e.g. `foo(x).bar(y)`) - Fix tool call capability detection - Tolerate `ensure_ascii` arg in `tojson` with support in Python jinja2 testing harness (supersedes google#84 - thanks @cnaples79 - & google#69 - thanks @rouseabout ),
ochafik
added a commit
to ochafik/minja
that referenced
this pull request
Nov 2, 2025
Fixes #4 - Fix parsing of values (nested method calls on function calls, e.g. `foo(x).bar(y)`) - Fix tool call capability detection - Tolerate `ensure_ascii` arg in `tojson` with support in Python jinja2 testing harness (supersedes google#84 - thanks @cnaples79 - & google#69 - thanks @rouseabout ),
ochafik
added a commit
to ochafik/minja
that referenced
this pull request
Nov 2, 2025
Fixes #4 - Fix parsing of values (nested method calls on function calls, e.g. `foo(x).bar(y)`) - Fix tool call capability detection - Tolerate `ensure_ascii` arg in `tojson` with support in Python jinja2 testing harness (supersedes google#84 - thanks @cnaples79 - & google#69 - thanks @rouseabout ),
Contributor
|
Hi @cnaples79 ,thanks for sending this, I've fix this in my for w/ ochafik#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept as an optional kwarg for the built-in filter, matching Jinja usage like . The flag is accepted and ignored (nlohmann::json dumps UTF-8 by default), preventing an "Unknown argument ensure_ascii" error.
Changes
Rationale
Some templates (e.g., in LLM contexts) call . Previously, this caused a runtime error. This change improves compatibility without altering output semantics.
Fixes #82