feat(gitter): git commit graph and patch ID caching, affected commits walking #4728
+1,624
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func loadRepositoryCache(cachePath string) (*pb.RepositoryCache, error) { | ||
| data, err := os.ReadFile(cachePath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| _, err := os.Stat(path.Join(repoPath, ".git")) | ||
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| deleteLastFetch(url) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| stats, err := os.Stat(archivePath) | ||
| if os.IsNotExist(err) || (err == nil && stats.ModTime().Before(accessTime)) { | ||
| logger.Info("Archiving git blob", slog.String("url", url)) | ||
| // Archive |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Ly-Joey
changed the title
| var newCommits []SHA1 | ||
|
|
||
| // Temp outFile for git log output | ||
| tmpFile, err := os.CreateTemp(r.repoPath, "git-log.out") |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| return err | ||
| } | ||
|
|
||
| return os.WriteFile(cachePath, data, 0600) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
And the start to git enumeration but the graph traversal needs more work
Because it is faster than stdout pipe after some experimentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #4508 & co.
Key changes:
API updates:
POST /cache: Triggers a clone / fetch and store the computed commit detailsPOST /affected-commits: accepts a list of events and returns the list of affected commits/getgitrenamed toGET /gitWIP:
/affected-commitsshould accept a list of ranges as valid request as wellTo be added in follow-up PR because this is getting big