feat: Support picosecond timestamp precision #1592
Conversation
Updated `BigQueryTimestamp` to correctly handle and preserve high-precision timestamp strings (e.g., picoseconds), which exceed the nanosecond limit of the internal `PreciseDate` representation. This matches functionality recently added to the Java client. * Used `big.js` to parse numeric timestamp strings to avoid precision loss associated with standard floating-point parsing. * Implemented logic to preserve the original fractional part of the timestamp string if it has more than 9 digits (picoseconds), ensuring `this.value` reflects the high-precision input. * Updated `fromFloatValue_` to use nanosecond precision instead of truncating to microseconds. * Added a safeguard to skip string replacement for scientific notation inputs to prevent generating invalid ISO strings. * Updated unit tests to reflect the new behavior and verify high-precision handling.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
product-auto-label
bot
added
size: m
Implemented support for picosecond timestamp precision in
BigQueryTimestamp. This ensures that high-precision timestamp inputs (strings or numbers) are preserved and correctly formatted, aligning with recent updates in the BigQuery ecosystem. The implementation usesbig.jsfor precise numeric parsing and string manipulation to bypass the nanosecond limitation of the underlyingPreciseDatelibrary.PR created automatically by Jules for task 6205571705196845849 started by @danieljbruce