Conversation
product-auto-label
bot
added
size: xs
Summary of ChangesHello @tswast, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's dependency configuration to support the upcoming pandas 3.0 release. This involves removing an outdated version constraint for pandas and making minor, targeted adjustments to existing test cases to ensure compatibility with changes in pandas' handling of missing data and specific BigQuery date parsing behaviors. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pandas dependency to allow for version 3.0 by removing the upper version constraint. The accompanying changes in the system tests, which involve updating the representation of missing values to pandas.NA and adjusting a datetime test value, appear to be necessary for compatibility with the newer pandas version. Overall, the changes look good, but I have one suggestion to clarify a comment in the test suite for better maintainability.
| # CSV loader in BigQuery currently requires leading 0s | ||
| # for TIMESTAMP but not DATETIME. See internal issue | ||
| # b/467399807. | ||
| datetime.datetime(1000, 1, 1), |
There was a problem hiding this comment.
The comment on lines 347-349 is a bit confusing. It states that the CSV loader's requirement for leading zeros applies to TIMESTAMP but not DATETIME. However, this change is made to datetime_col, which is defined as a DATETIME column in the table schema on line 374. Could you please clarify why this change is needed for a DATETIME column, or update the comment for future reference? This would help maintainers understand the reason for this specific test value.
There was a problem hiding this comment.
Correct. I use year >= 1000 so that no leading zeros are required.
|
Local tests pass with pandas 3.0.0rc0. Details |
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: xs
|
📢 Migration Notice: 📢 This library is moving to the google-cloud-python monorepo soon. We kept this PR open due to recent activity. We would like to finalize this PR so it can be merged if it is critical. If we don't hear from the PR author, we will close this PR in the next few days. The PR can then be re-opened in the monorepo once the migration is complete and work can continue there. |
4 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕