Adds max_dynamic_buffers_per_pipeline tests#2595
Adds max_dynamic_buffers_per_pipeline tests#2595lokokung wants to merge 1 commit intogpuweb:mainfrom
Conversation
|
Previews, as seen when this build job started (7015005): |
| // resources-of-type-per-stage is in pipeline layout creation. | ||
| // One bind group layout can have a maximum number of each type of binding *per stage* (which is | ||
| // different for each type). Test that the max works, then add one more entry of same-or-different | ||
| // type and same-or-different visibility. |
There was a problem hiding this comment.
All test description text should be in the .desc(), let's clean this up and move any useful info into there.
|
|
||
| // One pipeline layout can have a maximum number of each type of dynamic buffer per pipeline. Test | ||
| // that the max works, then add one more bind group layout with a buffer of the same-or-different | ||
| // type and same-or-different visibility. |
|
|
||
| // One bind group layout can have a maximum number of each type of dynamic buffer per pipeline. Test | ||
| // that the max works, then add one more buffer of the same-or-different type and same-or-different | ||
| // visibility. |
| - Test each binding type. | ||
| - Test that creation of a bind group layout using the maximum number of bindings works. | ||
| - Test that creation of a bind group layout using the maximum number of bindings + 1 fails. | ||
| - TODO(#230): Update to enforce per-stage and per-pipeline-layout limits on BGLs as well.` |
There was a problem hiding this comment.
This test hasn't actually changed. Am I reading right that the test was already up-to-date despite, just outdated comment and TODO?
| // One pipeline layout can have a maximum number of each type of dynamic buffer per pipeline. Test | ||
| // that the max works, then add one more bind group layout with a buffer of the same-or-different | ||
| // type and same-or-different visibility. | ||
| g.test('max_dynamic_buffers_per_pipeline,in_pipeline_layout') |
There was a problem hiding this comment.
This file is createBindGroupLayout so it's odd to have pipeline layout tests here (I know there are already some). I think we should move all of the limit tests that apply to both createBindGroupLayout and createPipelineLayout to a new file? (and leave behind notes in both createBindGroupLayout and createPipelineLayout's test files)
Can be a followup PR.
2 participants
Issue: #230
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off: