feat: remove immutable

[saihaj]

Closes #1025

[changeset-bot]

🦋 Changeset detected

Latest commit: 6951799

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphprotocol/graph-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
@graphprotocol/graph-cli	0.37.2-alpha-20221219142030-0cf2a37	npm ↗︎ unpkg ↗︎

[enisdenjo]

I'd say we keep ImmutableJS for now. This turned out to be a much bigger refactor than I expected, a lot of internals have ImmutableJS-like behaviour - some of them originating from graph-ts.

I worry that the CLI might become unstable with the size of this migration, we should queue up a breaking release. @saihaj @dotansimha thoughts?

[dotansimha]

I worry that the CLI might become unstable with the size of this migration, we should queue up a breaking release. @saihaj @dotansimha thoughts?

I think we can keep it for now, and just see if we can make it work fine with the TS migration. What breaking release you had in mind?

[enisdenjo]

What breaking release you had in mind?

Due to the size of the refactor, I have a feeling that we shouldn't push it as a minor or patch even if the user-facing API does not change.

[dotansimha]

Due to the size of the refactor, I have a feeling that we shouldn't push it as a minor or patch even if the user-facing API does not change.

I think we can start with a simple TS migration, and leave things like immutable as-is. If you feel like other things might change, we can introduce a major release if needed