2nd. Feat(Bento): First Game Hub and Top Action Bar #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two new modules, `gamehub` and `tutorial`, and integrates their respective UI components into the main Bento screen. - **feat(bento):** - Add `GameHubGrid` and `TutorialGrid` to the `BentoMainScreen`. - Adjust the height of existing grid items to accommodate the new components. - **feat(gamehub):** - Create the `gamehub` module. - Implement `GameHubGrid`, a carousel for game banners with pagination dots. - Add banner image assets for the game hub. - **feat(tutorial):** - Create the `tutorial` module. - Implement `TutorialGrid`, a pager component to display tutorial content with pagination. - **feat(design):** - Introduce `GridChip` composable for a consistent tagged look in grid cells. - Add `PaginationDot` composable for use in pagers and carousels. - **refactor(ltc):** - Refactor `FavoriteGrid` to use the new `GridChip` component. - Remove redundant `PaginationDot` implementation from `PriceTickerGrid` and use the new design-system version. - Simplify the header in `TransactionHistoryGrid`.
This commit introduces a dynamic icon to the dark mode toggle feature. The icon now changes to reflect the current theme (sun for light mode, moon for dark mode). The `DarkModeState` has been updated to include an `icon` property that returns the appropriate drawable resource based on the `isDarkMode` state. The `BentoDarkModeToggle` component now uses this new property to display the correct icon. Additionally, the `ic_dark_mode.xml` and `ic_light_mode.xml` drawable files were moved from the `app` module to the `design-system` module to be co-located with their usage. feat(design): remove notification and change order of top action bar
JosephSanjaya
changed the title
JosephSanjaya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📱 Description
This PR expands the Bento home experience with two new feature modules GameHub and Tutorial and introduces a series of design-system improvements. Several existing components are refactored to adopt new shared UI elements, resulting in a more consistent and scalable UI architecture.
Platform
🎯 Type of Change
📋 Changes
🧩 New Components & Modules
GameHubGridandTutorialGridto theBentoMainScreen.gamehubmodule.GameHubGrid, a carousel to display game banners with pagination dots.tutorialmodule.TutorialGrid, a pager for tutorial steps with pagination.🎨 Design-System Enhancements
GridChipcomposable for a unified tagged-label appearance across grids.PaginationDotcomposable.DarkModeStateupdated to expose aniconproperty based on the current theme.BentoDarkModeTogglenow displays a sun or moon icon accordingly.ic_dark_mode.xmlandic_light_mode.xmlinto thedesign-systemmodule.🔧 Refactoring
FavoriteGridto use the newGridChipcomponent.PaginationDotfromPriceTickerGridin favor of the design-system version.TransactionHistoryGrid.🔗 Related Issues
🧪 Tests Status
🎯 Reviewers
@kcw-grunt, @josikie