Multiple fixes #47
Merged
Multiple fixes #47
+36
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
… message directly Signed-off-by: Kai Wagner <kai.wagner@percona.com>
dutow
reviewed
Feb 9, 2026
| - if status.to_s == "reading" | ||
| - read_count = state[:read_count].to_i | ||
| - total_count = topic.message_count | ||
| - reading_unread_count = [total_count - read_count, 0].max |
Collaborator
There was a problem hiding this comment.
Why do we need the exact count? If the status is reading, we have at least one unread messages, and that's all we need here
Collaborator
Author
There was a problem hiding this comment.
because without we can show "has-new-replies" even when there are no unread messages? The envelope icon also only appears when reading_unread_count is positive, which is why we used the count to gate the has-new-replies or what am I missing?
| padding: var(--spacing-2) var(--spacing-4) var(--spacing-2) var(--spacing-2); | ||
| align-self: stretch; | ||
| height: 100%; | ||
| min-width: var(--topic-title-icons-width, 190px); |
Collaborator
Author
There was a problem hiding this comment.
Why would this look strange? Did you pull and look at it?
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
…unread message Signed-off-by: Kai Wagner <kai.wagner@percona.com>
dutow
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.