Skip to content

fix for #77 that flash message icons aren't shown correctly #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImTheKai merged 1 commit into from
Feb 19, 2026
Merged

fix for #77 that flash message icons aren't shown correctly #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions app/assets/stylesheets/components/form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,50 +29,28 @@ input[type=submit], input[type=button] {
display: flex;
align-items: center;
gap: var(--spacing-2);

&::before {
font-family: "Font Awesome 6 Free";
font-weight: 900;
font-size: var(--font-size-md);
}
}

.flash.alert {
background-color: var(--color-danger-soft);
color: var(--color-danger);
border: var(--border-width) solid var(--color-danger);

&::before {
content: "\f071"; /* fa-triangle-exclamation */
}
}

.flash.notice {
background-color: var(--color-success-soft);
color: var(--color-success);
border: var(--border-width) solid var(--color-success);

&::before {
content: "\f00c"; /* fa-check */
}
}

.flash.warning {
background-color: var(--color-warning-bg);
color: var(--color-warning-text);
border: var(--border-width) solid var(--color-warning);

&::before {
content: "\f06a"; /* fa-circle-exclamation */
}
}

.flash.info {
background-color: var(--color-info-soft);
color: var(--color-info);
border: var(--border-width) solid var(--color-info);

&::before {
content: "\f05a"; /* fa-circle-info */
}
}
12 changes: 12 additions & 0 deletions app/helpers/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,16 @@ def can_remove_note_mention?(mention, user)
false
end
end

def flash_icon(type)
icon_class = case type.to_s
when "alert" then "fa-solid fa-triangle-exclamation"
when "notice" then "fa-solid fa-check"
when "warning" then "fa-solid fa-circle-exclamation"
when "info" then "fa-solid fa-circle-info"
end
return unless icon_class

content_tag(:i, "", class: icon_class, aria: { hidden: "true" })
end
end
2 changes: 2 additions & 0 deletions app/views/layouts/application.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,13 @@ html data-theme="light"
main.container
- flash.each do |type, message|
.flash class=type
= flash_icon(type)
= message
= yield
- else
main.container
- flash.each do |type, message|
.flash class=type
= flash_icon(type)
= message
= yield