Exclude test data and tools from published packages #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'd probably wait on some input from others, but I personally think that having a blacklist would be better than a whitelist. Not sure though. |
Collaborator
|
We should do the same we do in rustybuzz: |
During our dependency reviews we discovered that the ttf-parser crate as uploaded to crates.io includes test data and additional tools that are not used by the rust code. This increases the package size and makes it harder to review the source code. This commit explicitly includes only relevant files. This helps to reduce the package size Before: 118 files, 1.0MiB (198.4KiB compressed) After: 75 files, 747.1KiB (140.6KiB compressed) Overall based on the reduction in the compressed package size and the current download numbers that results to a traffic reduction for crates.io of around 110GB / Month.
weiznich
force-pushed
the
remove_unneded_files
branch
from
23ba294 to
24901a8
Compare
Contributor
Author
|
I've updated the PR to use an exclude approach instead. In contranst to rustybuzz I also excluded:
Hopefully that's fine. The new size is: 76 files, 768.6KiB (146.5KiB compressed) |
Collaborator
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our dependency reviews we discovered that the ttf-parser crate as uploaded to crates.io includes test data and additional tools that are not used by the rust code. This increases the package size and makes it harder to review the source code.
This commit explicitly includes only relevant files. This helps to reduce the package size
Before: 118 files, 1.0MiB (198.4KiB compressed)
After: 75 files, 747.1KiB (140.6KiB compressed)
Overall based on the reduction in the compressed package size and the current download numbers that results to a traffic reduction for crates.io of around 110GB / Month.