more work on unchecked casts and type safety #11404
Conversation
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return determineMutabilityPlan( determineJavaTypeClass( javaType ), typeConfiguration ); | ||
| } | ||
|
|
||
| public <J> MutabilityPlan<J> determineMutabilityPlan(Class<J> javaTypeClass, TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| final CteContainer cteContainer = this.visitCteContainer( statement ); | ||
| final SqmStatement<?> oldSqmStatement = this.currentSqmStatement; | ||
| final var oldCteContainer = cteContainer; | ||
| final var cteContainer = this.visitCteContainer( statement ); |
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
| public <J> JavaType<J> findDescriptor(Class<J> javaType) { | ||
| //noinspection unchecked | ||
| return (JavaType<J>) findDescriptor( (Type) javaType ); | ||
| public <J> JavaType<J> findDescriptor(Class<J> javaClass) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| // } | ||
|
|
||
| @Internal // Can be demoted to private | ||
| public <J> JavaType<J> resolveDescriptor( |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| public <J> @Nullable BasicType<J> getBasicTypeForJavaType(Class<J> javaType) { | ||
| //noinspection unchecked | ||
| return (BasicType<J>) getBasicTypeForJavaType( (Type) javaType ); | ||
| public <J> @Nullable BasicType<J> getBasicTypeForJavaType(Class<J> javaClass) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| javaTypeDescriptor -> new BasicTypeImpl<>( javaTypeDescriptor, | ||
| javaTypeDescriptor.getRecommendedJdbcType( getCurrentBaseSqlTypeIndicators() ) ) ); | ||
| } | ||
| public <J> BasicType<J> standardBasicTypeForJavaType(Class<J> javaClass) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
this depended on the use of uncheckable casts to generic types enabled much less use of JavaTypeRegistry.getDescriptor()
1 participant
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.