fix: numerically unstable log-odds in ORPO loss#6407
Open
Mr-Neutr0n wants to merge 1 commit intohpcaitech:mainfrom
Open
fix: numerically unstable log-odds in ORPO loss#6407Mr-Neutr0n wants to merge 1 commit intohpcaitech:mainfrom
Mr-Neutr0n wants to merge 1 commit intohpcaitech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The ORPO loss (
OddsRatioLossinapplications/ColossalChat/coati/models/loss.py) computes log-odds using a numerically fragile pattern:This has two problems:
1.0001shifts the result away from the mathematically correct value, introducing a systematic bias into the loss.exp(logp) > 1.0001(which can happen due to floating-point imprecision, especially in mixed-precision training), the argument totorch.logbecomes negative, producing NaN and poisoning the training run.The mathematically correct log-odds formula is
log(p) - log(1-p) = logp - log(1 - exp(logp)).Fix
logpto(-inf, -eps]so thatexp(logp)is strictly less than 1, preventing both division by zero and negative arguments to log.torch.log(-torch.exp(logp) + 1.0001)withtorch.log1p(-torch.exp(logp)), which is the numerically correct and unbiased way to computelog(1 - exp(logp)).This eliminates both the NaN risk and the systematic bias from the hardcoded offset.