[Devstral] Make sure FP8 conversion works correctly #42715
+74
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: ministral3 |
4 tasks
SunMarc
approved these changes
Dec 10, 2025
|
|
||
| # No vision | ||
| if original_vision_config is None: | ||
| new_text_config = Ministral3Config(**new_text_config_kwargs, **get_maybe_quant_config()) |
Member
There was a problem hiding this comment.
let's just add the quantization config in new_config and not potentially in the new_text_config. In the config.json that you converted, everything looks good
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve script for FP8 conversion.
Tested on all relevant checkpoints (both Devstral 2 & Ministral 3B Reasoning & 14B - FP8)