Skip to content

Provide role scopes as csv to align with config #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilijamt merged 2 commits into from
Oct 17, 2025
Merged

Provide role scopes as csv to align with config #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c02f332
Provide role scopes as csv to align with config
danilobuerger Oct 9, 2025
25bcde6
add missing strings import
ilijamt Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions entry_role.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package gitlab
import (
"context"
"fmt"
"strings"
"time"

"github.com/hashicorp/vault/sdk/logical"
Expand Down Expand Up @@ -35,7 +36,7 @@ func (e EntryRole) LogicalResponseData() map[string]any {
"role_name": e.RoleName,
"path": e.Path,
"name": e.Name,
"scopes": e.Scopes,
"scopes": strings.Join(e.Scopes, ", "),
"access_level": e.AccessLevel.String(),
"ttl": int64(e.TTL / time.Second),
"token_type": e.TokenType.String(),
Expand All @@ -54,5 +55,4 @@ func getRole(ctx context.Context, name string, s logical.Storage) (role *EntryRo
_ = entry.DecodeJSON(role)
}
return role, err

}
9 changes: 5 additions & 4 deletions path_role_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"cmp"
"fmt"
"os"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -325,9 +326,9 @@ func TestPathRoles(t *testing.T) {
"path": "user",
"name": "Example user personal token",
"token_type": token.TypePersonal.String(),
"scopes": []string{
"scopes": strings.Join([]string{
"invalid_scope",
},
}, ", "),
},
})
require.Error(t, err)
Expand Down Expand Up @@ -423,10 +424,10 @@ func TestPathRoles(t *testing.T) {
"token_type": token.TypePersonal.String(),
"ttl": int64((5 * 24 * time.Hour).Seconds()),
"gitlab_revokes_token": false,
"scopes": []string{
"scopes": strings.Join([]string{
token.ScopeApi.String(),
token.ScopeReadRegistry.String(),
},
}, ", "),
}

// create a role
Expand Down
Loading