Fix memory leak in MessageDispatcher when outGate->deliver returns false#1091
Open
pablomadoery wants to merge 1 commit intoinet-framework:masterfrom
Open
Fix memory leak in MessageDispatcher when outGate->deliver returns false#1091pablomadoery wants to merge 1 commit intoinet-framework:masterfrom
pablomadoery wants to merge 1 commit intoinet-framework:masterfrom
Conversation
When a network interface goes down (e.g. in failure simulations), the local deliver() returns false. MessageDispatcher ignored this boolean return value, causing dropped packets to remain undeleted in memory. This commit deletes the packet correctly and calls take() prior to deletion to prevent object stealing warnings.
Contributor
|
This patch is difficult to review due to extensive code reformatting. Please remove the formatting changes and include only the functional changes. We aim to keep the entire codebase consistent with our existing style, which the formatting in this patch currently deviates from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a network interface goes down (e.g. in failure simulations), the local deliver() returns false. MessageDispatcher ignored this boolean return value, causing dropped packets to remain undeleted in memory. This commit deletes the packet correctly and calls take() prior to deletion to satisfy OMNeT++ object tracking conventions.