Fix memory leak in MessageDispatcher when outGate->deliver returns false#1094
Closed
pablomadoery wants to merge 1 commit intoinet-framework:masterfrom
Closed
Fix memory leak in MessageDispatcher when outGate->deliver returns false#1094pablomadoery wants to merge 1 commit intoinet-framework:masterfrom
pablomadoery wants to merge 1 commit intoinet-framework:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a packet memory leak in
inet/common/MessageDispatcher.cc.If
outGate->deliver(...)returns false (meaning the message could not be delivered natively by the channel), the current code effectively discards the pointer without deleting it, resulting in a memory leak.This PR adds a
keepMsgcheck to capture the return value ofdeliver(), and strictly deletes the message if it was not taken by the gate, matching OMNeT++ ownership semantics.Note: This supersedes PR #1091 with a clean functional-only patch that strictly preserves the original file formatting.