Skip to content

Update SDK Tag Filter Models to Support Multi-Type Values#11

Merged
Jayssgss merged 4 commits intomainfrom
Tag-Filter-update
Feb 4, 2026
Merged

Update SDK Tag Filter Models to Support Multi-Type Values#11
Jayssgss merged 4 commits intomainfrom
Tag-Filter-update

Conversation

@Jayssgss
Copy link
Collaborator

@Jayssgss Jayssgss commented Feb 3, 2026

Previously, the value field generated by the SDK was defined as a generic type, but in practice this led to Pydantic validation failures when users provided numeric or boolean inputs.

With the introduction of tag_filter_all_of_value, the field is now explicitly designed to accept string, number, and boolean values, eliminating those validation errors and making input handling more flexible and predictable.

This change aligns with the future OpenAPI specification, and the same behavior will be automatically generated from upcoming openapi.yaml versions.

Manual Changes

Version bumps across:

  • configuration.py
  • pyproject.toml
  • setup.py

Improved sanity_test.sh to support easier and more reliable local sanity testing

@Jayssgss Jayssgss requested a review from vipinmenon February 3, 2026 07:57
@vipinmenon
Copy link
Collaborator

vipinmenon commented Feb 4, 2026

@Jayssgss

  1. can you also document the changes made in the REST APIs that lead to these changes.
  2. Please give a meaningful title for this PR

@vipinmenon
Copy link
Collaborator

vipinmenon commented Feb 4, 2026

We should also consider adding test cases to validate the new type specifics.

@Jayssgss
Copy link
Collaborator Author

Jayssgss commented Feb 4, 2026

We should also consider adding test cases to validate the new type specifics.

Good point. In this case, the change is limited to the generated model classes.
The corresponding test cases are also auto-generated by the OpenAPI generator, and once these updates are incorporated into the OpenAPI spec, the tests will be generated automatically as well.

@Jayssgss Jayssgss changed the title Updating Tag_Filter Update SDK Tag Filter Models to Support Multi-Type Values Feb 4, 2026
@Jayssgss
Copy link
Collaborator Author

Jayssgss commented Feb 4, 2026

@Jayssgss

  1. can you also document the changes made in the REST APIs that lead to these changes.
  2. Please give a meaningful title for this PR

This change aligns the SDK models with the actual behavior of the Infrastructure Analyze REST APIs. The Analyze endpoints already support tag filter values as string, number, and boolean, but the SDK previously enforced a more restrictive type, which could result in validation errors for otherwise valid requests.

The SDK has now been updated to reflect the API contract correctly, ensuring consistency between the SDK and the documented REST behavior.

These changes correspond to the Infrastructure Analyze endpoints documented in IBM API Hub:

I have also updated the title now.

@vipinmenon
Copy link
Collaborator

LGTM

@Jayssgss Jayssgss requested a review from sunjit10 February 4, 2026 13:40
@Jayssgss Jayssgss merged commit d0e82af into main Feb 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants