-
Notifications
You must be signed in to change notification settings - Fork 39
chore: skipped aws dynamodb currency updates #2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abhilash-sivan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| }); | ||
|
|
||
| execSync("git add '*package.json' package-lock.json", { cwd }); | ||
| execSync(`git commit -m "build: bumped ${packagesToUpdate.join(', ')} to ${targetVersion}"`, { cwd }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see: d296ade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline and decided to skip the updates for now, this will be fixed #2306 is merged
|



@aws-sdk/client-dynamodb and @aws-sdk/lib-dynamodb were both listed in currencies.json and were being updated independently. However, @aws-sdk/client-dynamodb is a peer dependency of @aws-sdk/lib-dynamodb.
Because of this, when the currency update job ran, it often failed with an npm peer dependency conflict. In practice, these two packages must be updated simultaneously to the same version.
Currently, updates for these dependencies are being skipped to avoid npm peer dependency conflicts.
reference https://jsw.ibm.com/browse/INSTA-74688