Fix index_add kernel for empty index tensor #2487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the early-exit condition in the index_add kernel to properly handle empty index tensors, addressing issue #2473. The fix simplifies the logic by removing an unnecessary dimension check that prevented the early exit from working correctly for 1-dimensional tensors.
Key Changes:
- Simplified the early-exit condition to check for empty index or self tensors regardless of dimensionality
- Added regression test to verify
index_addworks correctly with empty index tensors
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/Indexing.cpp | Simplified early-exit condition by removing dimension check, allowing proper handling of empty index tensors for all dimensions |
| test/regressions/test_index_and_index_put.py | Added test case test_index_add_empty to verify correct behavior with empty index tensors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chunhuanMeng
approved these changes
Dec 10, 2025
CuiYifeng
force-pushed
the
yifeng/fix_index_add
branch
from
f1739da to
1c29504
Compare
yucai-intel
approved these changes
Dec 12, 2025
CuiYifeng
force-pushed
the
yifeng/fix_index_add
branch
from
1c29504 to
2d4b57a
Compare
etaf
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #2473
This PR is to correct the early-exit condition for empty index tensor.