Conversation
| # Note: this RegEx is obtained by executing WEBrick::HTTPUtils::UNESCAPED, | ||
| # splitting it over multiple lines and using the x modifier to make this possible. |
There was a problem hiding this comment.
I wonder if it would be better to either copy over the smaller pieces of this Regex, as WEBrick does it, or at least make that a perma-link to the version from which it was taken (i.e., https://github.com/ruby/webrick/blob/9350944141a3f15acda9c79edd5393289c098e04/lib/webrick/httputils.rb#L498). Or… both!?!
There was a problem hiding this comment.
I did not copy the smaller pieces of the regex but used the complete result instead on purpose. We do not need the smaller piecers. We do not use them by ourselves. It may improve understandability of where this is coming from, but to use the smaller piecer, we would also need to copy the custom _make_regex method and logic of what the UNESCAPED constant is (UNESCAPED = _make_regex(control+space+delims+unwise+nonascii)). This would result in duplicating more code.
Instead I think it is better to just execute WEBrick::HTTPUtils::UNESCAPED and copying the result as I did here.
Good suggestion about the permalink though. Fixed that :)
Was only used to URL escape a string (also see interagent@585de87). Seems a bit overkill to include a complete webserver only for this. We therefore only include this method ourselves. Note: also tried CGI.escape and URI.encode_www_form_component but those don't work since they escape too much (e.g. colons).
kreintjes
force-pushed
the
fix/remove-webrick-dependency
branch
from
2d9414b to
f47e077
Compare
|
Could anybody have a look at this and merge it in please? E.g. @schneems ? |
|
Can we please have this merged and released? The inclusion of webrick as a dependency causes it to be installed in the For this reason webrick was removed as a dependency from rackup |
3 participants
No description provided.