Fix pagination test for conversations with API v2.14 #506
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversations pagination test was failing because it relied on pre-existing conversations in the test account. When the default Intercom API version was bumped from 2.11 to 2.14 in v7.0.0, the API returned fewer conversations, causing the test to fail. This fix adds a setup function that creates 2 test conversations before running the pagination test, making the test reliable regardless of the API version or existing data in the test account. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
VedranZoricic
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The v7.0.0 release failed to publish to npm because the pagination test for conversations was failing in CI.
The test was relying on pre-existing conversations in the test account, but when the default Intercom API version was upgraded from 2.11 to 2.14 in v7.0.0, API v2.14 returns fewer conversations (only 1 instead of the expected 2+). This caused the assertion
expect(pagerCount).toBeGreaterThan(1)to fail.This needs to be fixed so we can successfully publish v7.0.0 to npm.
How?
Added a
setupfunction to the conversations pagination test case that creates its own test data:This makes the test self-contained and reliable regardless of the API version or existing data in the test account, matching the pattern already used by the "notes" pagination test case.