Refactor GitHub Actions Workflows #177
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-kaestner
changed the title
felix-kaestner
force-pushed
the
refactor-actions
branch
5 times, most recently
from
0d74501 to
c16b734
Compare
hardikdr
added
the
area/metal-automation
felix-kaestner
force-pushed
the
refactor-actions
branch
2 times, most recently
from
dddf821 to
9ad8003
Compare
Merging this branch changes the coverage (2 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Introduce a CI workflow that validates all kustomization.yaml files in the config directory on pull requests to main. This ensures Kustomize configurations remain valid and buildable.
felix-kaestner
force-pushed
the
pause
branch
from
d2c200c to
c74cb7e
Compare
felix-kaestner
force-pushed
the
refactor-actions
branch
2 times, most recently
from
7c11f7d to
3a209e0
Compare
Enhance the github action workflow with Go build caching, PR triggers for validation builds, and tag-based releases. Images are only pushed on main branch commits and version tags, while PRs only build without pushing. The introduced caching uses the experimental GitHub Actions Cache Exporter Backend to fetch and upload cache blocks for the container image build. Additionally, buildkit cache mounts are being preserved between builds by injecting a temporary container with the cache mount data in the Docker build steps. The procedure is outlined in the Docker Documentation[^1]. [^1]: https://docs.docker.com/build/ci/github-actions/cache/#github-cache.
Introduce a workflow that automatically labels pull requests with size indicators (XS, S, M, L, XL) based on lines changed. This helps reviewers quickly assess PR scope and prioritize reviews.
Introduce a workflow that packages and pushes the Helm chart to ghcr.io as an OCI artifact. Release tags use semantic versioning while branch builds use commit-based versions. PRs only validate the chart package.
Introduce a workflow that runs code generation targets and detects any uncommitted changes. This ensures generated code, docs, charts, and formatting are always up to date in pull requests.
felix-kaestner
force-pushed
the
refactor-actions
branch
from
3a209e0 to
73e206d
Compare
Stop using go-makefile-maker for GitHub Actions workflow generation. With recent additions of custom workflows, maintaining consistency between auto-generated and manually written pipelines became impractical. The effort to update all workflows already requires reviewing each one, so auto-generation provides diminishing value. Additionally, some generated workflows like CodeQL are redundant (enabled at repo level) while others like test-chart required manual modifications anyway. Going forward, all workflows will be manually maintained for this project, providing full control over CI/CD configuration.
felix-kaestner
force-pushed
the
refactor-actions
branch
from
73e206d to
1fd2089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we stop using go-makefile-maker for GitHub Actions workflow generation. With recent additions of custom workflows, maintaining consistency between auto-generated and manually written pipelines became impractical. The effort to update all workflows already requires reviewing each one, so auto-generation provides diminishing value. Additionally, some generated workflows like CodeQL are redundant (enabled at repo level) while others like test-chart or publishing the docker image to
ghcr.iorequired manual modifications anyway.Going forward, all workflows will be manually maintained for this project, providing full control over CI/CD configuration.