Skip to content

Conversation

@felix-kaestner
Copy link
Contributor

This patch defaults the vrf to use for the keepalive link of the VPCDomain in Cisco NX-OS to use the "management" vrf. This reflects the default used by the device1.

Footnotes

  1. https://www.cisco.com/c/en/us/td/docs/dcn/nx-os/nexus9000/106x/configuration/interfaces/cisco-nexus-9000-series-nx-os-interfaces-configuration-guide-release-106x/m_configuring_vpcs_9x.html#:~:text=the%20system%20uses%20the%20management%20VRF%20by%20default

@felix-kaestner felix-kaestner requested a review from a team as a code owner February 9, 2026 12:08
@felix-kaestner felix-kaestner changed the title [NX-OS]: Use management by default for VPCDomain if not specified [NX-OS]: Use management vrf by default for VPCDomain if not specified Feb 9, 2026
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 10.92% (-0.01%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/grpc.go 13.33% (ø) 15 2 13
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.07% (-0.00%) 1477 (+1) 1 1476 (+1) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/vpc.go 12.00% (ø) 25 3 22
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/vrf.go 100.00% (ø) 6 6 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/dns_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/ntp_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/snmp_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/syslog_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/vpc_test.go

@felix-kaestner felix-kaestner merged commit 36478b9 into main Feb 9, 2026
11 of 12 checks passed
@felix-kaestner felix-kaestner deleted the default-mgmt-vrf-vpc branch February 9, 2026 13:07
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Feb 10, 2026
@hardikdr hardikdr added this to Roadmap Feb 10, 2026
@github-project-automation github-project-automation bot moved this to Done in Roadmap Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants