-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Adds devcontainer instructions for Isaac Lab #4294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile SummaryThis PR adds VS Code Dev Container support to Isaac Lab, enabling developers to work in a containerized environment with all dependencies pre-configured. Key Changes:
Implementation Details:
Issues Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant VSCode as VS Code
participant DevContainer as Dev Container Extension
participant Docker as Docker Engine
participant Compose as Docker Compose
participant Container as Isaac Lab Container
User->>VSCode: Open Isaac Lab folder
User->>VSCode: Command: "Reopen in Container"
VSCode->>DevContainer: Read .devcontainer/devcontainer.json
DevContainer->>Docker: Check if image exists
alt Image doesn't exist
DevContainer->>Compose: docker-compose -f docker/docker-compose.yaml build isaac-lab-base
Compose->>Docker: Build Isaac Lab base image
Docker-->>Compose: Build complete
end
DevContainer->>Compose: docker-compose up isaac-lab-base
Compose->>Docker: Start container with GPU, network=host
Docker->>Container: Mount workspace at /workspace/isaaclab
Docker->>Container: Set environment variables (DISPLAY, ISAACLAB_PATH, etc.)
Docker->>Container: Mount .Xauthority for X11
Container-->>Docker: Container running
DevContainer->>Container: Connect VS Code Server
DevContainer->>Container: Install extensions (ms-python.python)
Container->>Container: Run postCreateCommand
Container-->>DevContainer: Extensions installed
DevContainer-->>VSCode: Container ready
VSCode-->>User: Workspace opened in container
User->>Container: Run commands via VS Code terminal
Container-->>User: Execute with Isaac Sim Python interpreter
User->>VSCode: Close/Exit
VSCode->>DevContainer: Shutdown
DevContainer->>Compose: docker-compose stop (shutdownAction: stopCompose)
Compose->>Container: Stop container
Container-->>Compose: Stopped
Compose-->>DevContainer: Container stopped
DevContainer-->>VSCode: Cleanup complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
.devcontainer/devcontainer.json, line 67 (link)logic: references
ms-python.black-formatterextension, but it's not listed in theextensionsarray on line 49. Add it to ensure the formatter is available.And update the extensions array:
"extensions": [ "ms-python.python", "ms-python.black-formatter", "ms-python.isort" ]
3 files reviewed, 1 comment
Description
This MR adds devcontainer integration for Isaac Lab.
I am facing some issues triggering a build form inside the container but I can safely build one on the terminal and attach the IDe to it. Looking for suggestions from the community!
Fixes # (issue)
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there