Skip to content

Fix noiselib to properly compile on android (float literals). Also fixed NoiseLib.glsllib code indent #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joliver82 wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −4
Open

Fix noiselib to properly compile on android (float literals). Also fixed NoiseLib.glsllib code indent #2622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f639007
Fix noiselib to properly compile on android (float literals)
Feb 21, 2026
6f53cda
Fixed indent
Feb 21, 2026
683d140
Fixed GLSLcompato to avoid issues in legacy GLES devices <130 not hav…
Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion jme3-core/src/main/resources/Common/ShaderLib/GLSLCompat.glsllib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#if __VERSION__ >= 130
precision highp sampler2DArray;
#endif
precision highp sampler2DArray;
precision highp sampler2DShadow;
precision highp samplerCube;
precision highp sampler3D;
Expand Down
6 changes: 3 additions & 3 deletions jme3-core/src/main/resources/Common/ShaderLib/NoiseLib.glsllib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

float noise(vec2 n) {
const vec2 d = vec2(0.0, 1.0);
vec2 b = floor(n), f = smoothstep(vec2(0.0), vec2(1.0), fract(n));
vec2 b = floor(n), f = smoothstep(vec2(0.0), vec2(1.0), fract(n));
return mix(mix(rand(b), rand(b + d.yx), f.x), mix(rand(b + d.xy), rand(b + d.yy), f.x), f.y);
}

Expand Down Expand Up @@ -90,8 +90,8 @@

//used to reference the same float generated by noise for all shaders, so afflictionness appears to spread and splat naturally
float getStaticNoiseVar0(vec3 wPos, float afflictionVar){
float noiseVar0 = Noise3D(wPos, 28);
float noiseVar1 = Noise3D(wPos, 3);
float noiseVar0 = Noise3D(wPos, 28.0);
float noiseVar1 = Noise3D(wPos, 3.0);
float noiseVar2 = Noise3D(wPos, 0.8);

float noiseVar = ((noiseVar0 + noiseVar1) * 0.4) + (noiseVar2 * 0.2 * afflictionVar);
Expand Down