Skip to content

Conversation

@Divyansh200102
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Added documentation to proto/api_v3/query_service.proto specifying that the HTTP API expects the attributes parameter as a URL-encoded JSON string map
  • Follows the same documentation pattern used for other fields like start_time_min
  • Regenerated swagger/api_v3/query_service.swagger.json to reflect the updated documentation
  • Example format: {"http.status_code":"200","error":"true"}
  • Also fixed the CONTRIBUTING.md by correcting the title for thrift commands.

How was this change tested?

  • Ran make proto-all to regenerate all auto-generated files
  • Verified swagger documentation was updated correctly
  • Ran make test-ci - all tests passed

Checklist

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yurishkuro
Copy link
Member

please make sure commits are signed

@Divyansh200102 Divyansh200102 force-pushed the document-attributes-http-format branch from 8cf8b9f to 31720f1 Compare November 11, 2025 04:29
@Divyansh200102
Copy link
Contributor Author

@yurishkuro can we merge this PR?

@yurishkuro yurishkuro enabled auto-merge November 11, 2025 18:08
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b55d868) to head (31720f1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          422       422           
=========================================
  Hits           422       422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yurishkuro yurishkuro added this pull request to the merge queue Nov 11, 2025
Merged via the queue into jaegertracing:main with commit ac6612b Nov 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants