Skip to content

Conversation

@SomilJain0112
Copy link
Contributor

@SomilJain0112 SomilJain0112 commented Oct 10, 2025

Which problem is this PR solving?

#7223

Description of the changes

a. Add IndexSpanAlias and IndexServiceAlias config fields
b. Use explicit aliases when provided instead of prefix pattern

How was this change tested?

Through local testing

Checklist

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.53%. Comparing base (d843097) to head (4fa145a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7550      +/-   ##
==========================================
- Coverage   95.61%   95.53%   -0.09%     
==========================================
  Files         311      311              
  Lines       15511    15537      +26     
==========================================
+ Hits        14831    14843      +12     
- Misses        532      547      +15     
+ Partials      148      147       -1     
Flag Coverage Δ
badger_v1 9.87% <0.00%> (-0.04%) ⬇️
badger_v2 2.06% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 14.01% <0.00%> (-0.05%) ⬇️
cassandra-4.x-v2-auto 2.05% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 2.05% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 14.01% <0.00%> (-0.05%) ⬇️
cassandra-5.x-v2-auto 2.05% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 2.05% <0.00%> (-0.01%) ⬇️
clickhouse 1.97% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 ?
elasticsearch-7.x-v1 ?
elasticsearch-8.x-v1 ?
elasticsearch-8.x-v2 2.06% <0.00%> (-0.01%) ⬇️
elasticsearch-9.x-v2 2.06% <0.00%> (-0.01%) ⬇️
grpc_v1 9.66% <0.00%> (-0.03%) ⬇️
grpc_v2 2.06% <0.00%> (-0.01%) ⬇️
kafka-3.x-v2 2.06% <0.00%> (-0.01%) ⬇️
memory_v2 2.06% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 18.99% <57.89%> (+0.10%) ⬆️
opensearch-2.x-v1 ?
opensearch-2.x-v2 2.06% <0.00%> (-0.01%) ⬇️
opensearch-3.x-v2 2.06% <0.00%> (-0.01%) ⬇️
query 2.06% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.59% <0.00%> (-0.01%) ⬇️
unittests 94.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Metrics Comparison Summary

Total changes across all snapshots: 53

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

  • 🆕 Added: 53 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics

🆕 Added Metrics

  • http_server_request_body_size_bytes (18 variants)
View diff sample
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...
- `http_server_request_duration_seconds` (17 variants)
View diff sample
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...
- `http_server_response_body_size_bytes` (18 variants)
View diff sample
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro,
Please review the PR. Please let me know if any changes are required and I am going in the right direction for solving this issue or not.
Thanks!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro,
Please review this PR.
Thanks!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro ,
Please review this PR as well.
Thanks!

@SomilJain0112 SomilJain0112 force-pushed the fix/Added-fields-for-explicit-alias branch from bcc7b86 to 83eb73c Compare October 18, 2025 05:47
@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro ,
I have resolved all the comments made by you, please review the changes.
Thanks!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro , I have resolved comments. Please review here!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro ,
Addressed your above comments and made changes accordingly in the code. Kindly review it.
Thanks!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro
Now we will have complete control over naming that's what we were trying to achieve from this issue.
Please review, Thanks!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro
Please review this PR, Thanks!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro @mahadzaryab1
Please review this PR.
Thanks!

@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro Are we going in right direction to solve this issue?

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for delay. Looks good, with a couple of minor comments

@SomilJain0112 SomilJain0112 force-pushed the fix/Added-fields-for-explicit-alias branch from 0d6d3bc to ef82f79 Compare December 9, 2025 18:13
@SomilJain0112
Copy link
Contributor Author

Hii @yurishkuro
Removed redundant checks as it was not needed, removed irrelevant comment as well and removed an unnecessary testcase as well. Resolved all of your latest comments. Please have a look again.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants