[breaking] remove ParameterValue and ParameterDual#219
Conversation
test/test_JuMP.jl
Outdated
| @constraint(model, cons, x * p >= 3) | ||
| @objective(model, Min, 2x) | ||
| optimize!(model) | ||
| @test isapprox(dual(ParameterRef(p)), -6; atol = 1e-4) |
There was a problem hiding this comment.
Okay. This one tripped me up for a while to figure out what was going on. Getting ConstraintDual falls back to get_fallback. Is that correct? It it just the same as the dual of a fixed variable? I don't really understand how this worked.
There was a problem hiding this comment.
Or maybe I need to delete this, and error in MOI?
There was a problem hiding this comment.
just noticed now, this is multiplicative parameter, we should error
There was a problem hiding this comment.
Yeah I now error, which prevents the get_fallback from triggering. Previously I threw a GetAttributeNotAllowed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 99.62% 99.67% +0.04%
==========================================
Files 9 9
Lines 1882 1861 -21
==========================================
- Hits 1875 1855 -20
+ Misses 7 6 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll write some changelog docs because this does break a few things |
2 participants
No description provided.