Skip to content

Conversation

@brichet
Copy link
Collaborator

@brichet brichet commented Dec 8, 2025

This PR fixes the tooltip on the send button.

This PR restore the helper text containing the shortcut to send a message.

Part of #303

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/restore_helper_text

@brichet brichet added the enhancement New feature or request label Dec 8, 2025
@brichet brichet self-assigned this Dec 8, 2025
@jtpio
Copy link
Member

jtpio commented Dec 8, 2025

Thanks for looking into adding this back.

Wondering what this would look like when the toolbar has many buttons, like in jupyterlite/ai#218?

Otherwise, maybe we don't really need to add it back?

@brichet
Copy link
Collaborator Author

brichet commented Dec 8, 2025

Otherwise, maybe we don't really need to add it back?

I often find it useful, each chat system has it's own way to add a new line, and I'm often confused. In the context of AI, it's annoying to send an incomplete message when you only wanted to add a new line.
But maybe we can show this information in a different way, like a tooltip on the send button for example.

@jtpio
Copy link
Member

jtpio commented Dec 10, 2025

each chat system has it's own way to add a new line

Nowadays they often seem to default to (at least for the most popular AI chats / IDEs):

  • Enter: send the message
  • Shift Enter: new line

Also after checking a couple of them, most don't seem to be showing such helper text.

But maybe we can show this information in a different way, like a tooltip on the send button for example.

Otherwise this could be a setting, to let administrators choose if they want to show it to their users?

@brichet
Copy link
Collaborator Author

brichet commented Dec 11, 2025

Otherwise this could be a setting, to let administrators choose if they want to show it to their users?

It may be a bit overkill to add a settings for it. If we go in that direction, let remove the option to set it up, and keep one way only to send message and one to add a new line (this is not my favorite option, though).

But maybe we can show this information in a different way, like a tooltip on the send button for example.

To make sure we're talking about the same thing, I was thinking of something like what we have in notebook buttons:

Screenshot from 2025-12-11 10-16-07

We could have a tooltip like Send message (Enter) or Send message (Shift+Enter), and that could help deducting how to add a new line.

@nakul-py
Copy link
Contributor

To make sure we're talking about the same thing, I was thinking of something like what we have in notebook buttons:
We could have a tooltip like Send message (Enter) or Send message (Shift+Enter), and that could help deducting how to add a new line.

I agree with this.

@jtpio
Copy link
Member

jtpio commented Dec 11, 2025

We could have a tooltip like Send message (Enter) or Send message (Shift+Enter), and that could help deducting how to add a new line.

Sounds like a good tradeoff 👍

@brichet
Copy link
Collaborator Author

brichet commented Dec 11, 2025

Actually the tooltip was already there, but not initialized.

I updated the PR to revert the previous changes and fix tooltip initialization.

@brichet brichet changed the title Restore the helper text in input Fix the send button tooltip Dec 11, 2025
@brichet brichet added bug Something isn't working and removed enhancement New feature or request labels Dec 12, 2025
@brichet
Copy link
Collaborator Author

brichet commented Dec 12, 2025

Merging it, it is only a small bug fix.

@brichet brichet merged commit fbcdf8d into jupyterlab:main Dec 12, 2025
26 of 28 checks passed
@brichet brichet deleted the restore_helper_text branch December 12, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants