Added support for CUSIP securities (bonds, t-bills, etc)#377
Open
alp3 wants to merge 1 commit intokedder:masterfrom
Open
Added support for CUSIP securities (bonds, t-bills, etc)#377alp3 wants to merge 1 commit intokedder:masterfrom
alp3 wants to merge 1 commit intokedder:masterfrom
Conversation
…w listed under DEBTINFO with UNIQUEIDTYPE set to CUSIP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for CUSIP securities which are now listed under DEBTINFO with UNIQUEIDTYPE set to CUSIP. Test added: test_cusip_writes_debtinfo_and_cusip_type
Also, I fixed a logic bug in statement.py - I changed an if to an elif. I believe this was the intent. The bug prevented self.trntype "BUYDEBT" to ever be possible.
I'm new to using ofxstatement - thanks for creating/maintaining this project. I'm happy to change around the PR however you like, just let me know.